Just installed the module to test it out and the first thing I noticed was a warning:

	Unable to locate compiler.jar in Google Closure Compiler module directory /sites/all/modules/contrib/closure_compiler/google_closure_compiler).

I'm thinking this would be better off moved out to the libraries folder.

Comments

nburles’s picture

nburles commented
Status: Active » Postponed

I looked into using the "libraries" module a while back, and I believe it only supports php, css, and js files (http://drupalcontrib.org/api/drupal/contributions!libraries!libraries.ap...). So although I could simply look for the compiler.jar file within the libraries directory, it seemed sort of pointless to me!

Another reason I ultimately decided not to move the compiler.jar (or rather not to give users the choice) is that in my understanding, the libraries folder is intended for libraries which may be used by multiple modules - those that are actually used by the site, rather than just in offline processing.

Having said that, I'd be happy to commit a patch so the module looks both in the libraries folder and the module folder if someone wants to make one.

Thanks