In the controller and form files, We should use dependency injection.

CommentFileSizeAuthor
#6 3070792-6.patch6.38 KBravi.shankar
#4 3070792-4.patch6.38 KBravi.shankar
#2 3070792-2.patch5.74 KBravi.shankar

Comments

anmolgoyal74 created an issue. See original summary.

ravi.shankar’s picture

ravi.shankar commented
Status: Active » Needs review
StatusFileSize
new 3070792-2.patch5.74 KB

I have fixed.

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Needs work 
-    $entityManager = \Drupal::service('entity_field.manager');
+    $entityManager = $this->entityFieldManager;

Need to change the variable name.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3070792-4.patch6.38 KB

I have modified.

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Needs work

Patch not able to apply.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3070792-6.patch6.38 KB

It's applying for me.

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.