Closed (works as designed)
Project:
Clean Markup
Version:
7.x-2.7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Mar 2015 at 14:59 UTC
Updated:
23 Mar 2015 at 14:48 UTC
Jump to comment: Most recent
Comments
Comment #1
jremydeaton commentedComment #2
mparker17I'm unable to reproduce this with the Navigation menu block on a fresh D7.36 site using the Bartik theme and the
clean_markup_blocksmodule, version 2.7.But, so that I can be 100% sure, could I trouble you to tell me:
... this information will help me to determine if whether there's a problem with the Clean Markup module, an incompatibility between the Clean Markup module and the theme you are using, and/or a problem with a specific configuration that's preventing it from working.
Thanks!
Comment #3
jremydeaton commentedAnswers to your questions:
Theme = bootstrap (This might be the issue here)
Which element = I'v tried them all, but I mainly just wanted a div
Which block = Menu block
Setting values=
Block Title = string ("my title")
Clean Markup options = no additional attributes
Clean Markup options = did NOT set visually hide block title
Hope that helps. Sorry so late getting back to you. Weekend and all.
Comment #4
mparker17I'll check it out. Thanks!
Comment #5
mparker17@jremydeaton,
I installed Drupal 7.36, Clean Markup
7.x-2.7, and the Bootstrap theme version7.x-3.0, and I replaced Bootstrap'stheme/block/block.tpl.phpwith Clean Markup'smodules/clean_markup_blocks/block.tpl.phpto make it work.I can confirm that Bootstrap interferes with Clean Markup's ability to override the block title wrapper.
After a bit of investigation, I can confirm this is due to the following line in Bootstrap's
theme/block/block.vars.php::bootstrap_process_block():... and that removing this line fixes the problem. It's safe to do this because Clean Markup already takes care of this in
modules/clean_markup_blocks/clean_markup_blocks.module::clean_markup_blocks_process_block().Unfortunately, because theme functions in themes always run after theme functions in modules, there's not really any way for me to fix this in the clean_markup module.
A few tips:
bootstrap_process_block()in the sub-theme. This will make it easier to update the Bootstrap theme in the future (e.g.: if the theme maintainers release bug fixes or security fixes).Comment #6
jremydeaton commentedStill not working after removing bootstrap_process_block() on my initial site. Problem has to be within another module, Because I did a fresh install with no bootstrap theme or sub-theme and it worked.
initial site - Tried to change it to just a paragraph tag for testing and the element is removed completely.
fresh install - element shows up as expected.
In my free time I will try to pinpoint which module is causing the issue, and report back here. In the meantime, this issue should be closed as the module works as expected.
Thank you.