Problem/Motivation

The items under "Filter processing order" in a Text format ("Filtered HTML") from "Text formats and editors" /admin/config/content/formats/ are too close to each other, and need more space.

This is in Drupal 11.4.5, Drupal 10 is fine.

Steps to reproduce

Open a Text format from "Text formats and editors" /admin/config/content/formats/ and see items under "Filter processing order" are too close to each other.

Compact Filter processing order

The problem is that td height is set to zero, maybe due to CCS updates in Claro theme.

Proposed resolution

Make sure there is an appropriate amount of spacing for cells (td's), by checking the layout in Drupal 10/11/12 on for example these pages:

  • Filter processing order list on Text formats and editors pages (/admin/config/content/formats/manage/basic_html)
  • Node list on Content page (/admin/content)

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ressa created an issue. See original summary.

ressa’s picture

Issue summary: View changes
StatusFileSize
new44.81 KB

Add an image.

djg_tram’s picture

We would need to identify if this is influenced by any other themes or versions. I can't reproduce it right away, this is how it looks for me:

Screenshot

djg_tram’s picture

StatusFileSize
new16.72 KB
ressa’s picture

Issue summary: View changes

I forgot to include Drupal core version, my bad. This happens in Drupal 11, not D10.

djg_tram’s picture

I have 11.4.1 in my virtual server I use for testing, this is apparently not latest one?

ressa’s picture

Status: Active » Postponed

Sorry, you're right! I should have verified in another instance, which I did just now, and it looks fine. But still, it only collapses in this theme, so I'll try to figure out why it happens, and return when I have some news.

ressa’s picture

Issue summary: View changes
Status: Postponed » Needs review

Actually, there seems to be a problem. To make sure, I tried in another Drupal 11.4.1 installation, and it also had the same issue. Perhaps you can try in a fresh Drupal 11.4.5 locally, for example with DDEV?

The problem is that cell height is set to zero, but somehow the cell is not squashed in Drupal 10, probably by some other elements' CSS rule, which may have been adjusted or removed in Drupal 11?

th,
td {
  height: 0;
  padding: 2px;
}
djg_tram’s picture

I use https://github.com/wodby/docker4drupal and this seems to be lagging which is strange. Both because this isn't my prior experience (upgrades aren't immediate, of course, but in a few days time) and because the last commit was two days ago.

ressa’s picture

I misunderstood, and thought that you were using a dev environment, which made it difficult for you to update to the latest 11.4.1, which is why I suggested something flexible like DDEV. But that other system probably works just as well.

I hope you get a chance to spin up a fresh instance, and check if you see the same thing? Even if you can't replicate it, perhaps you can check if the patch could be possible?

djg_tram’s picture

Yes, that's a dev environment. A ready-made Docker with the whole environment prepared and assembled but you don't upgrade it the usual way, composer, because the core files are in the package itself. You just change the .env file that pulls the upgraded Drupal image the next time around. There will be tons of different ways to have a local environment for a local Drupal but this always worked OK for me, so I got used to it.

ressa’s picture

Thanks for clarifying, in that case, I think you should seriously consider giving DDEV a test drive, it's a very flexible and efficient tool, and selected by the Drupal community as the recommended dev environment: https://www.drupal.org/docs/getting-started/installing-drupal/install-dr....

djg_tram’s picture

If I change the height to 20 rem, I can see the change. But 0 and 2 rem display the same to me. I'd rather see it in action before fixing. :-)

djg_tram’s picture

Well, I might give it a try but I can't directly see how the creature comforts already present in Docker4Drupal like Traefik, Mailhog and others can be included. Probably could be installed but those are just existing extra images that only require uncommenting in docker-compose.yml to be included. I need some of those in some sites, not every single time, and this makes it rather easy.

ressa’s picture

Yes, I know how you can get attached to a system that works well for you ...

DDEV includes a lot of great tools like Mailpit, and for most other popular programs, there is a DDEV Add-on.

If you find a feature that is missing, the DDEV team members are usually open to adding it: https://github.com/ddev/ddev/issues.

ressa’s picture

I tried to compare the behaviour in different versions of Drupal 10/11/12, and saw differences. It seems like Claro CSS was updated in #3608172: Claro table cells should have minimum height, which could be a factor ... height was changed to min-height for td's, perhaps the tablesort issue is also relevant?

Since simply changing the height is probably not the right solution, I am changing Status.

PS. I recalled the times I made major switches in dev environment this morning, and I had internal resistance every time. It took some efforts to go from LAMP > Vlad > Drupal VM > Lando > DDEV :) But I am glad I did it, every time it was an upgrade.