According to the Claro style guide, only the primary tabs are collapsed on mobile. The secondary tabs are all displayed. However, this could become very overloaded if there are many tabs.
You will find the Claro style guide here or you can look at the screenshot below.
Maybe it would make sense to set an upper limit for secondary tabs, where you say that, for example, from 5 secondary tabs, they are also collapsed on mobile.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | After.png | 60.9 KB | Moni_10 |
| #10 | Before.png | 39.52 KB | Moni_10 |
| #4 | Screenshot from 2023-05-18 13-21-40.png | 24.03 KB | m.stenta |
| Bildschirmfoto 2022-05-13 um 14.37.16.png | 319.92 KB | romina_ferrario |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
m.stentaWe may be interested in this within the farmOS distribution also. We make heavy use of tabs (both primary and secondary), and we have a lot of users on mobile. We use Gin (which inherits the secondary tab styling/behavior from Claro).
I'm curious if there is a mechanism we could use to try collapsing our secondary tabs? I'm not familiar with how this behavior gets applied to the primary tabs currently. If I find any more information I will share it here.
Comment #4
m.stentaWe came up with our own solution in farmOS, which basically overrides the templates and CSS to make the secondary tabs collapse in the same way that the primary ones do. Screenshot attached. (Note that we are using the Gin theme, which inherits the tab behavior from Claro).
Would this be worth pursuing as a core enhancement?
Comment #9
hille commentedI have changed the behaviour of the secondary tabs to be more useable with small displays.
Its basically the same as the primary tabs.
Comment #10
Moni_10 commentedHii I've tested the above MR. Seems working fine for me. So, Moving this to RTBC
Here's before and after screenshot.
Comment #11
luenemannThe current approach of MR !4262 always collapses when the secondary tabs overflow. The proposed solution is different.
Set to Needs work (NW) for Issue summary update (IS update).
I think a claro maintainer should have a look at the proposed solution.
Comment #13
nayana_mvr commentedPipeline was not shown in the Merge Request and there was an option to create pipeline. After clicking that, the .gitlab-ci.yml file changes got committed to the MR. Not sure why that happened and why that file was missing in the first place. I tried creating a new branch but that also doesn't have .gitlab-ci.yml. Can somebody please look into it? Sorry for the inconvenience caused.
Comment #15
quietone commentedThe Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.
Comment #16
smustgrave commentedClaro has moved to contrib