Problem/Motivation

I'm open to the possibility others may disagree with this, but I'd like to have it discussed in an issue.
I've found that the box-shadow on buttons/dropbuttons look good in the Figma designs, but somehow don't translate well in their implementation in Claro. The shadow seems to close to the color of the button itself, which results in it looking misshapen or misaligned instead of having a shadow.

Current Appearance: Button With Shadow

Proposed Appearance: Button Without Shadow

Current Appearance: Dropbutton With Shadow

Proposed Appearance: Dropbutton Without Shadow

Proposed resolution

  • Determine if this should be changed at all
  • If it should be changed, determine if the box-shadow should be restyled or removed altogether
  • Implement the change

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 After shadow.png68.72 KBsagarmohite0031
#14 Before shadow.png69.12 KBsagarmohite0031
dropbutton-without-shadow.png46.56 KBbnjmnm
dropbutton-with-shadow.png39.13 KBbnjmnm
button-without-drop-shadow.png23.78 KBbnjmnm
button-with-drop-shadow.png24.73 KBbnjmnm

Issue fork drupal-3159889

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented

@bnjmnm who could do the design review?

saurav-drupal-dev’s picture

saurav-drupal-dev commented

I have created MR with suggested solution.

Before

Only local images are allowed.

After

Only local images are allowed.

nishamukta made their first commit to this issue’s fork.

saurav-drupal-dev’s picture

saurav-drupal-dev commented
Status: Active » Needs review

saurav-drupal-dev opened merge request !10330

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

For design review

sagarmohite0031’s picture

sagarmohite0031 commented
StatusFileSize
new Before shadow.png69.12 KB
new After shadow.png68.72 KB

Hello,
Tested and verified on Drupal 11, MR applied successfully.
Its working as expected
Attaching before and after screenshots.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

smustgrave’s picture

smustgrave commented
Project: Drupal core » Claro
Version: main » 3.0.x-dev
Component: Claro theme » Code

Claro has moved to contrib