Problem/Motivation

We currently only have one label for search and output in the data, but in some cases it makes sense to have them differently, for example to show more information in search than in output. So let's split these variables.

This also allows further contextual information in the search output.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor_mentions-3582400

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !46

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » grevil
Status: Active » Needs review

Just a POC to give you an idea, please test and review.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs review » Reviewed & tested by the community

LGTM and works as expected!

  • grevil committed a7c46e00 on 3.0.x authored by anybody 
    feat: #3582400 Split label into search_label and (output) label
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

grevil’s picture

grevil commented
Status: Fixed » Needs work

Sorry, should have tested the hook integration more carefully. Currently the output is overwritten with the search label.

anybody opened merge request !48

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.