Problem/Motivation

In Drupal 10.6.3 the 'Save' and 'Cancel' buttons are not displaying on the Div Manager dialog. I haven't had a chance to test this on earlier versions of Drupal, but I did test this on a clean install of 10.6.3.

Here's a screenshot:
Shows missing buttons on dialog

Looking in the inspector, it appears that the svgs for those buttons aren't getting injected:
Shows missing svg tag in code

Steps to reproduce

  1. Install Drupal 10.6.3
  2. Install and enable CKEditor Div Manager
  3. Add CKEditor Div Manager to a text format
  4. Add or edit some content with the text format
  5. Attempt to use Div Manager and observe the missing buttons

Proposed resolution

After digging through the code and comparing to some code in core, I noticed that the js/ckeditor5_plugins/divManagerPlugin/src/divmanagerview.js file on line 8 has this code:
import { IconCheck, IconCancel } from 'ckeditor5/src/core';

But in Drupal core, in the core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/ui/textalternativeformview.js file, the line has changed from that to this:
import { IconCheck, IconCancel } from '@ckeditor/ckeditor5-icons';

It looks like this change occurred in 10.5.0. After recompiling the JS code with this change, that seems to fix the issue.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
div_manager_missing_svg.jpg154.55 KBjonathan_w
div_manager_missing_buttons.jpg29.68 KBjonathan_w

Issue fork ckeditor_div_manager-3576864

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan_w created an issue. See original summary.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Yes I have dealt with this in other CKEditor5 projects. CKEditor 45+ in Drupal 10.6 and 11.2 has a breaking change for icons. Looks like you have pretty much found and identified the changes needed.

jonathan_w opened merge request !11

jonathan_w’s picture

jonathan_w
he/him
Primary language English
Location Omaha, NE, USA
commented
Assigned: jonathan_w » Unassigned

Alrighty, I've created an MR with this fix. My package-lock.json file updated during this process and upgraded a bunch of packages, but I'm not sure if the maintainers want that included with this fix or not. So, I can remove that if y'all would prefer. But here's the fix nonetheless.

Oh, and I actually made the change to the 3.0.x branch. I just couldn't select that for the Version in the issue here. Cheers!

jonathan_w’s picture

jonathan_w
he/him
Primary language English
Location Omaha, NE, USA
commented

I suppose for this fix, you may need a release that's for Drupal 10.5+ since that's when this change was introduced, eh? Or do you know if this particular change will still work correctly for older versions of Drupal, @smulvih2?