Problem/Motivation

Before CKEditor 5 can be moved to core, all of its dependencies have to be evaluated following the core process https://www.drupal.org/about/core/policies/core-dependencies-policies/co...

Proposed resolution

After #3227853: Remove dependency on Vue.js has been resolved, evaluate all remaining dependencies.

  • ckeditor5, ckeditor5-dev-utils
    • Maintainership of the package: CKEditor 5 is maintained professionally by CKSource.
    • Security policies of the package: Security policies are documented in the repository.
    • Expected release and support cycles: Major releases are shipped every couple of months. Minor releases are shipped more frequently. Only one major release is supported at once. Note that CKEditor 5 is not following semver. Their versioning policy mention that minor releases could include "minor" BC breaking changes.
    • Code quality: CKEditor 5 code quality is and excellent and the project has very good test coverage.
    • Other dependencies it would add, if any: many additional dependencies
  • webpack, webpack-cli, raw-loader, terser-webpack-plugin
    • Maintainership of the package
      These packages are maintained by the webpack community. Most of the core team members and contributors in the ecosystem do the work in their free time. However, they have pretty solid funding on Open Collective.
    • Security policies of the package: Security policies are documented in the Webpack repository.
    • Expected release and support cycles: Major releases are happening only every few years. Minor and patch releases are coming at a steady pace. I couldn't find whether Webpack 4.0.0 (the previous major release) is still supported. However, they supported it for at least 6 months since the release of Webpack 5.0.0.
    • Code quality: We haven't had the need to evaluate Webpack code base because they have very solid documentation, and it has worked out of the box without any issues for all of our use cases.
    • Other dependencies it would add, if any: many additional dev dependencies.
CommentFileSizeAuthor
#7 dependencies.txt6.51 KBlauriii
#5 dependencies.txt71.83 KBlauriii

Issue fork ckeditor5-3227858

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lauriii created an issue. See original summary.

wim leers’s picture

Title: [PP-1] Evaluate dependencies » Evaluate dependencies
Assigned: Unassigned » lauriii
Priority: Normal » Major
Status: Postponed » Active
Issue tags: +beta blocker

lauriii’s picture

FYI, js/build/admin/admin.js is removed as part of the MR as the only change as the result of running yarn build. It is not caused by this but it's something that should have been removed in #3227853: Remove dependency on Vue.js.

lauriii’s picture

Issue summary: View changes
StatusFileSize
new71.83 KB

Added proposed dependency evaluations to IS.

lauriii’s picture

I posted dependency tree on ##5. Something to note is that CKEditor 5 is the only production dependency. However, most of the dependencies are used as part of the code compilation and therefore could have an impact on the code that we include in the application.

lauriii’s picture

StatusFileSize
new6.51 KB

Here's a cleaned up list which only contains new dependencies.

  • lauriii committed dd7996d on 1.0.x
    Issue #3227858 by lauriii: Evaluate dependencies
    
lauriii’s picture

Status: Active » Fixed

Merging since there's no changes to production code as part of the MR.

wim leers’s picture

Nice that we were able to remove two dev dependencies! 🥳

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.