Problem/Motivation

#3215005: Move custom CKEditor 5 drupal plugins into module added the plugin build process to the module. Now we should add the admin ui build. Currently, the admin UI lives here https://github.com/zrpnr/ckeditor5-drupal-admin. When it is updated, we take the compiled from that libraries dist/ and copy the contents to this module's admin.js. It's more elegant to have that build process and source code be part of the CKEditor 5 module.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor5-3216255

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: Unassigned » bnjmnm

bnjmnm opened merge request !46

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review

Discussed how to implement this with @lauriii and we agreed it would be best to provide a separate dir/package.json for the time being. The build process can potentially be centralized with the plugin build process at a later date, and may be worth holding off on until there's confirmation that the current Vue-using approach is deemed OK.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: bnjmnm » Unassigned

lauriii made their first commit to this issue’s fork.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

Thank you @bnjmnm, looks good!

  • bnjmnm committed 24c387e on 1.0.x 
    Issue #3216255 by bnjmnm, lauriii: Move admin UI build process into...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.