Would be good to run this through Coder. There's some i18n stuff which might be important for national campaigns.

Some potential problems with "Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized." and "Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)"

But this should just e marked as a todo item or something that someone can contribute back to the project.

CommentFileSizeAuthor
#2 citcon-coder-review-2131819-2.patch18.54 KBmgifford
#1 citcon-coder-review-2131819-1.patch16.25 KBmgifford

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new citcon-coder-review-2131819-1.patch16.25 KB
mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new citcon-coder-review-2131819-2.patch18.54 KB

Oops, forgot these.

Tarnjit’s picture

Tarnjit commented

After applying this patch ( citcon-coder-review-2131819-2.patch), I had the following errors:

Notice: Undefined index: field in citcon_email_form_citcon_supporter_form_alter() (line 539 of /data/www/dm7/sites/imdb.com/modules/citcon/modules/citcon_email/citcon_email.module).
Warning: array_keys() expects parameter 1 to be array, null given in citcon_email_form_citcon_supporter_form_alter() (line 539 of /data/www/dm7/sites/imdb.com/modules/citcon/modules/citcon_email/citcon_email.module).
Warning: Invalid argument supplied for foreach() in citcon_email_form_citcon_supporter_form_alter() (line 539 of /data/www/dm7/sites/imdb.com/modules/citcon/modules/citcon_email/citcon_email.module).

In addition the drop down menu for "Supporter type" no longer worked. No options in the drop down. So therefore none of the module worked.