Closed (fixed)
Project:
Chatblock
Version:
5.x-1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Apr 2007 at 14:46 UTC
Updated:
23 Apr 2007 at 23:03 UTC
Jump to comment: Most recent file
2 problem
(1) The parameter $url could be detected.
(2) The iFrame address went wrong if the site is not using clean url
I've changed to code so the module would:
(1) automatically detect the path for the module file; and
(2) use Drupal API url() to define iFrame's source path
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | chatblock.module_0.patch | 11.14 KB | yookoala |
| chatblock.module.patch | 11.34 KB | yookoala |
Comments
Comment #1
dwees commentedPatch applied and slightly modified. This should fix some issues other users were having. Also noticed you've improved the theming of the module so that it should work better with translations. Much appreciated. I'm working on improving the JavaScript as well so it works for more users. This should make it into the next release, which will be in a couple of days.
Thanks,
Dave
Comment #2
yookoala commentedUpdated the patch to use Drupal API drupal_get_path() to handle the same thing. I used an ugly str_replace() method at the last patch.
good day :P
Comment #3
dwees commentedUrl functions updated, and patch (mostly) incorporated into latest version which should be available for download in a few hours.
Dave
Comment #4
dwees commentedClosing issue.
Dave