Child issue for #2708777: Write/migrate integration tests, for the CDNCssUrlTestCase portion.

CommentFileSizeAuthor
#2 2745115-2.patch1.79 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
Status: Active » Needs review
StatusFileSize
new 2745115-2.patch1.79 KB

\Drupal\Core\Asset\CssOptimizer now has test coverage in \Drupal\Tests\Core\Asset\CssOptimizerUnitTest to ensure that file_create_url() is called on all files.

However, that still leaves the case of ensuring that CSS aggregates are always up-to-date: they should contain either

  • no CDN URLs
  • only CDN URLs

This is already true. However, currently, aggregate A can contain no CDN URLs, and aggregate B can contain only CDN URLs. This is confusing, but it works: #2745109: Files referenced in CSS aggregates should not have CDN URLs: already root-relative, and they cannot be safely made forever cacheable anyway. See that issue for determining how to continue with that.

In any case, this means we can now get rid of the old test coverage.

  • Wim Leers committed 09fc288 on 8.x-3.x 
    Issue #2745115 by Wim Leers: Port CDNCssUrlTestCase in tests/cdn.test
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2745109: Files referenced in CSS aggregates should not have CDN URLs: already root-relative, and they cannot be safely made forever cacheable anyway

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.