Problem/Motivation

There is an invalid HTML in the image captcha preview:

ImageCaptchaSettingsForm.php, line 378

      $available_fonts['BUILTIN'] = $this->t('PHP built-in font: <img src="@font_preview_url" alt="@title" title="@title"', [
        '@font_preview_url' => Url::fromRoute('image_captcha.font_preview', ['token' => 'BUILTIN'])
          ->toString(),
        '@title' => $title,
      ])->__toString();

This translatable string is missing the closing > . While most browsers will fix this by themselves, it still is invalid code and it causes errors in UI translation, when a foreign language tries to import a PO translation file of that invalid string.

CommentFileSizeAuthor
#4 3266543-4.patch858 bytesvictoria-marina

Comments

hudri created an issue. See original summary.

hudri’s picture

Issue summary: View changes
victoria-marina’s picture

Assigned: Unassigned » victoria-marina

I'll work on this.

victoria-marina’s picture

Assigned: victoria-marina » Unassigned
Status: Active » Needs review
StatusFileSize
new858 bytes

Here is a patch. Hope it fits!

Guilherme Rabelo’s picture

Assigned: Unassigned » Guilherme Rabelo

I will review this.

Guilherme Rabelo’s picture

Assigned: Guilherme Rabelo » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch in comment #4 fixed the issue and everything seems to work weel.
Moving to RTBC!

japerry’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.