Fix coding standards & replace the deprecated methods

The module is still in alpha state, we'll get them fixed before a beta release. There are still lots of good candidates now to get them in before this. Changing it to postponed for now.

Thanks for filing the issue.

Reopening it as I have closed couple of(~5) issues in favor of this one.
Here's the patch

Here's the Round 2 with more fixes

Here's the interdiff

@elachlan ,
Can we get this fixed as its a huge patch and will be painful later to reroll it.

Thanks! We're very now very near to it http://pareview.sh/pareview/httpgitdrupalorgprojectcaptchagit-8x-1x

@Naveen
Fix coding standard issues. The patch given in #5 is failed to apply.

Here is the patch with code standards

I have rerolled the patch, Fix coding standards & replace the deprecated methods against 8.x-1.x

Adding patch again.

Added the new patch.

Kindly review.
Thanks!

Last submitted patch has some mistakes in comments formatting.
1.

+// '@disable' => $captcha_point->url('disable',
+// ['query' => Drupal::destination()->getAsArray()]),
+// '@enable' => $captcha_point->url('enable',
+// ['query' => Drupal::destination()->getAsArray()]),

What the reason of adding more strings. Better to investigate why those strings are commented and still present in the code.
2.

+ *    The utf8 string which will be used to split in characters.

In this place indent is 4 spaces, but should be 2.
3.

+/*
+TODO: write test for CAPTCHAs on admin pages
+TODO: test for default challenge type
+TODO: test about placement (comment form, node forms, log in form, etc)
+TODO: test if captcha_cron does it work right
+TODO: test custom CAPTCHA validation stuff
+TODO: test if entry on status report (Already X blocked form submissions)
+TODO: test space ignoring validation of image CAPTCHA
+TODO: refactor the 'comment_body[0][value]' stuff.
+ */

Multiline comment formatting is incorrect.

@minakshiPh please take a look on the documentation https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...

Hi @ddrozdik,

Thanks for reviewing my patch !!!

Have made the required changes as per #38

Kindly review.
Thanks!

Hi @elachlan,

Thanks for reviewing my patch!

Added new patch to fix automated test issue Automated Testing Issue

Kindly review.
Thanks!

Added new patch to resolve pareview issues as mentioned in #44.

Kindly review.
Thanks!

Added patch to resolve pareview issues as mentioned in #44.

Kindly review.
Thanks!

Hi @elachlan,

Thanks for your helpful comments.

I have made changes in some files and tried to fix the errors.

Kindly review.
Thanks!

Added new patch to fix other pareview errors.

Kindly review.
Thanks!

Added new patch to fix other pareview errors.

Kindly review.
Thanks!

Let's mark this issue as fixed, and in the future create a new issue if you want fix coding standards. Now this issue has many patches with different contexts and discussions, and it is difficult to follow it and find something.