I will provide a small patch which fixes the error message described in the title of this issue.

CommentFileSizeAuthor
#3 bu-undefined_index-1991940-3.patch709 byteserik frèrejean
#2 undefined_offset-1991940-2.patch783 bytesscuba_fly
#1 undefined_offset-1991940-1.patch783 bytesguillaumev

Comments

guillaumev’s picture

guillaumev commented
Status: Active » Needs review
StatusFileSize
new undefined_offset-1991940-1.patch783 bytes

Here is the patch.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
StatusFileSize
new undefined_offset-1991940-2.patch783 bytes

Looking at the code I think the default value should be 2
which is the index of safari 4

the error occurred because index 4 was out of the scope of the array.

Included a patch:

erik frèrejean’s picture

erik frèrejean
Primary language Dutch
Location 🏴‍☠️
commented
StatusFileSize
new bu-undefined_index-1991940-3.patch709 bytes

Besides updating the index value, bu_get_versions() should validate whether the requested index actually exists.

pebosi’s picture

pebosi commented
Status: Needs review » Fixed

Fixed in latest dev. Thanks.

pebosi’s picture

pebosi commented
Status: Fixed » Closed (fixed)

Closing.