Problem/Motivation

If there are extra spaces in the empty array, which is apparently common, the lines aren't removed. Additionally, I added a check to remove the file if we can assume that this wasn't customized. It's an assumption, but sites can always restore if it

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bs_base-3609479

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir opened merge request !38

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community

Checked, looks good to me, @berdir just two small cosmetics things, not that important.

Do you want this merged or you want to test it a bit more?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

> Do you want this merged or you want to test it a bit more?

I rolled it out to a few projects, seems to be working well. deleted it in most cases, one example where it had an extra include it did not as expected. It's still easy to miss the warning message, we could make it a confirmation message that have to confirm?

pivica’s picture

pivica commented

> we could make it a confirmation message that have to confirm?

yeah that makes sense i think