Problem/Motivation

In theme-options.yml file we only have access to built-in SASS functions. Currently, we are not able to load and use custom functions in theme yaml files.

Proposed resolution

If the theme is defining sass/_functions.scss file load it automatically on the start of the gulp sass and sass:dev tasks so it is available everywhere, including theme-options.yml.

Remaining tasks

- Update documentation with this new feature.

CommentFileSizeAuthor
#13 interdiff-3093783-12-13.txt2.36 KBpivica
#13 yaml-support-sass-functions-3093783-13.patch17.17 KBpivica
#12 yaml-support-sass-functions-3093783-12.patch16.69 KBpivica
#11 yaml-support-sass-functions-3093783-11.patch16.71 KBpivica
#10 yaml-support-sass-functions-3093783-10.patch16.65 KBpivica
#9 yaml-support-sass-functions-3093783-8-composer.patch17.82 KBpivica
#9 yaml-support-sass-functions-3093783-8.patch17.73 KBpivica
#7 yaml-support-sass-functions-3093783-7.patch17.7 KBpivica
#6 yaml-support-sass-functions-3093783-6.patch17.6 KBpivica
#5 yaml-support-sass-functions-3093783-5.patch10.18 KBpivica
#3 yaml-support-sass-functions-3093783-3.patch10.11 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Issue summary: View changes
pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-3.patch10.11 KB

The first patch, adds two new packages through2 for injecting functions into the gulp stream and gulp-debug for some debug info.

More testing is needed.

pivica’s picture

pivica commented
Title: Support sass/_functions.scss which are available in theme-options.ym » Support sass/_functions.scss which are available in theme-options.yml
pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-5.patch10.18 KB

Forgot to add some stuff to the previous patch.

pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-6.patch17.6 KB

Updated bs_bootstrap, some small fixes in a generator.

pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-7.patch17.7 KB

And here is a composer friendly patch against alpha7 release.

pivica’s picture

pivica commented
Status: Active » Needs review
Issue tags: +next-release
pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-8.patch17.73 KB
new yaml-support-sass-functions-3093783-8-composer.patch17.82 KB

We should also check the current theme for sass/_functions.scss.

pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-10.patch16.65 KB

An updated patch against latest dev version.

pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-11.patch16.71 KB

Messed up the previous patch a bit, here is a version that should work.

pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-12.patch16.69 KB

Actually i forgot to push one commit to 8.x-1.x branch when tagging alpha8...

Hopefully, now the patch is correct.

pivica’s picture

pivica commented
StatusFileSize
new yaml-support-sass-functions-3093783-13.patch17.17 KB
new interdiff-3093783-12-13.txt2.36 KB

Cleaned the main gulp-tasks.js a bit.

  • pivica committed 410172b on 8.x-1.x 
    Issue #3093783 by pivica: Support sass/_functions.scss which are...
pivica’s picture

pivica commented
Status: Needs review » Fixed
Issue tags: -next-release

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.