Closed (fixed)
Project:
BrowserID
Version:
7.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2013 at 15:11 UTC
Updated:
18 May 2013 at 12:50 UTC
Should this module be marked as deprecated in favour of http://drupal.org/project/persona ?
Comments
Comment #1
icecreamyou commentedI noticed that the Persona module now has a stable release (congratulations) -- I am planning to do a code review as soon as I get a chance and move forward with this accordingly.
Comment #2
jbrown commentedOkay - it currently disables the page cache, but I'll have this fixed very soon. Perhaps wait until 7.x-1.2?
Comment #3
jbrown commentedI've released 7.x-1.2 - I'd be honoured for you to review it: http://drupal.org/node/1970726
Comment #4
icecreamyou commentedOkay. I'll try to get some time this weekend.
Comment #5
icecreamyou commentedI apologize for the delay -- I should have this done by the end of the week.
Comment #6
icecreamyou commentedLooks good. I changed BrowserID project page. A couple of comments below -- but I also want to note that I'm impressed with the frequency of updates to the Persona module and the rate at which it has been improving. :)
$_SERVER['SERVER_NAME'] . ':' . $_SERVER['SERVER_PORT']should be a secure alternative to$_SERVER['HTTP_HOST'].All these things are pretty minor issues. Nice work. I do have one question: what happens if the user has JS disabled and the site has "takeover" mode enabled?
Comment #7
jbrown commentedThanks so much Isaac! I pasted your code review into a new issue for the Persona module: #1986722: Review IceCreamYou's code review