Closed (won't fix)
Project:
BrowserID
Version:
7.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Jul 2011 at 19:22 UTC
Updated:
11 Nov 2011 at 10:08 UTC
See attached patch, or is there a reason for your helper function?
Regards
| Comment | File | Size | Author |
|---|---|---|---|
| menu_callback.patch | 1.42 KB | pebosi |
Comments
Comment #1
icecreamyou commentedWell first of all the $path variable is used several more times in browserid_login_button().
And about not using drupal_get_form() as the menu callback -- definitely not a bug, doing it this way works -- I tried to use drupal_get_form as the callback in another module I was working on recently and discovered that it now returns the form array instead of the rendered form so it wasn't working as the callback.
If it works, fine. I don't really care. It's 5 lines of code. It doesn't slow anything down -- it's just an administrative menu. But fix the patch and I'll try it.
Comment #2
icecreamyou commented