select elements get "form-control" class via select.html.twig. This is not correct imho, as Bootstrap uses "form-select" class for select elements, see https://getbootstrap.com/docs/5.2/forms/select/
use a select element with Bootstrap theme and inspect the class.
change class to "form-select" in select.html.twig
create a patch
bootstrap styling according to "form-select" class
na
na
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | select_should_get__form-select__class_instead_of__form-control-3330099-003.patch | 1.07 KB | stefan.korn |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
stefan.kornComment #3
stefan.kornLooking a bit deeper into this, Drupal is itself already adding "form-select" in template_preprocess_select. So imho the select.html.twig can be removed from Bootstrap theme, since the only relevant change to core's version seems to be adding the "form-control" class. But this is not necessary for a bootstrap select and in someway it is even incorrect.
So providing another patch for deleting the select.html.twig.
Comment #4
jannakha commentedneeds to be ported to v4
Comment #5
jannakha commentedComment #6
anirudhsingh19 commentedworking on this!
Comment #8
anirudhsingh19 commentedRemoved select.html.twig as suggested in #3. Please review.
Comment #9
jannakha commentedthank you for your contribution.
tested, works as expected.
ready for release.
Comment #10
vladimirausThank you. Committed.