Nature of the bug:

  • an enabled "Iconize Buttons" theme setting
  • a form contains a list of submit buttons
  • one of the submit buttons contains a text "Save"
  • need to provide a custom icon (or disable it at all) for the button

Seems with the current implementation of the _bootstrap_iconize_button() it's impossible to pass a custom icon for an element via the "#icon" property. I propose to add a isset($element['#icon'])check.

CommentFileSizeAuthor
#2 bootstrap-custom-icon-3070426-1-D7.patch667 byteschalk

Comments

Chalk created an issue. See original summary.

chalk’s picture

chalk commented
Status: Active » Needs review
StatusFileSize
new bootstrap-custom-icon-3070426-1-D7.patch667 bytes

With this patch it's possible to provide a custom icon for an element via the "#icon" property.

chalk’s picture

chalk commented
Assigned: chalk » Unassigned
markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 8.x-4.x-dev
Status: Needs review » Needs work
Issue tags: +needs backport to 7.x-3.x, +needs backport to 8.x-3.x

This needs to be fixed in HEAD first and backported to the other branches:

https://git.drupalcode.org/project/bootstrap/blob/8.x-4.x/src/Utility/El...

shelane’s picture

shelane
Primary language English
commented
Status: Needs work » Closed (won't fix)

This theme will not be supported for Bootstrap 4. See alternative themes for this support.