Hello,

I have start my redesign from the SASS starterkit include in Bootstrap 3 by copy the directory to a custom new subtheme. But when I’m logged, and have the admin bar horizontal at top, this one recover my primary menu.

When I inspect the code, I have this line:
<body class="toolbar-tray-open toolbar-horizontal toolbar-fixed fontyourface user-logged-in path-node page-node-type-page navbar-is-static-top has-glyphicons" style="padding-top: 40px;">

This css inline style="padding-top: 40px;" and the good value seems to be 79px instead 40px. I don’t know where it come from and where in can change it to override.

Thank you from your help.

Comments

floown created an issue. See original summary.

floown’s picture

floown commented

When I clic two times on "Manage", in the admin bar, the code change and the page display is correct:
<body class="toolbar-horizontal toolbar-fixed fontyourface user-logged-in path-frontpage page-node-type-book navbar-is-static-top has-glyphicons toolbar-tray-open" style="padding-top: 79px;">

So the _toolbar.scss works only in this case and apply the code:

  // Horizontal.
  &.toolbar-horizontal.toolbar-tray-open .navbar-fixed-top {
    top: 79px;
  }
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Closed (outdated)

The CSS styles have been moved to a separate repository, see #2852156-4: Move "overrides" source files and generated CSS to separate project.

floown’s picture

floown commented

I don’t use CDN for Bootstrap and I don’t really understand what manipulation I should do with your present link.

I have solved my problem in desactivated 'Settings tray' in modules.

markhalliwell’s picture

markhalliwell
Primary language English
commented

This isn't about the CDN. This project is no longer the source of any customized CSS styles, including the ones previously located in the starterkits:

Less starterkit source files:
http://cgit.drupalcode.org/bootstrap/tree/starterkits/less/less?id=d77a8...

Moved to:
https://github.com/unicorn-fail/drupal-bootstrap-styles/tree/master/src/...

Sass starterkit source files:
http://cgit.drupalcode.org/bootstrap/tree/starterkits/sass/scss?id=d77a8...

Moved to:
https://github.com/unicorn-fail/drupal-bootstrap-styles/tree/master/src/...

Thus, the file you're referencing _toolbar.scss, is now located at:
https://github.com/unicorn-fail/drupal-bootstrap-styles/blob/master/src/...

Issues/fixes/PRs should be filed there now is what I'm saying.

I'm still working on updating the documentation and change record to reflect these changes.

floown’s picture

floown commented

Ah, ok!

And is the release of a new version of the module with all the changes included for Bootstrap 3? Or Bootstrap 4? You advise me to wait for the moment and not to work on my theme for my next site in development?

markhalliwell’s picture

markhalliwell
Primary language English
commented

I plan on rolling out a new 8.x-3.x and 7.x-3.x release sometime soon.

Also, this is a [base] theme, not a module.

floown’s picture

floown commented

Will the module be installed as an update in a transparent way and will the addition of a sub-theme be done in the same way?

Have a nice day!

markhalliwell’s picture

markhalliwell
Primary language English
commented

This isn't a module... and I'm not entirely sure what you're asking.

floown’s picture

floown commented

Oh sorry, I meant the Boostrap theme: will creating a sub-theme be done as usual by copying the sass directory into a custom theme? Actually, I just wanted to know what's going to change for us, with regard to the tutorials you can find on the internet. I just started following this resource just yesterday: https://www.youtube.com/watch?v=ZrJ5s3-bqR4&index=6&list=PLL73GOh1BF-lue... which is complete and works very well.

markhalliwell’s picture

markhalliwell
Primary language English
commented

As I said above, I'm still working on updating the documentation and change record to reflect these changes.

This means that the official documentation on https://drupal-bootstrap.org will be updated with the proper steps on how to create a sub-theme.

What this also means, however, is that any existing tutorials or videos will technically become out-of-date.

The steps they take will not reflect the (likely additional) steps needed after this change. At least, not 100%.

It'll probably be fairly easy to infer which additional steps are needed, but I suspect until new tutorials/videos are made, you'll need to follow along with the official documentation and change records so you know how to proceed.