If you add a core image field to a content type the upload button in the edit form is not blue like the file upload field button.

The class btn-primary is simply missing.

CommentFileSizeAuthor
#14 8.x-3.x-2834683-14.patch758 bytesThew
#10 8.x-3.x-2834683-10.patch491 bytesThew
#5 backported-7.x-3.x-2834683-5.patch652 bytesThew
#3 Issue-2834683-by-hass-Core-image-field-has-no-colore.patch840 byteshass

Comments

hass created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Category: Bug report » Feature request
Priority: Normal » Minor

Patches are welcome.

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new Issue-2834683-by-hass-Core-image-field-has-no-colore.patch840 bytes
markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Status: Needs review » Needs work
Issue tags: +needs backport to 7.x-3.x
Thew’s picture

Thew commented
Status: Needs work » Needs review
Issue tags: -needs backport to 7.x-3.x
StatusFileSize
new backported-7.x-3.x-2834683-5.patch652 bytes

Backported patch for 7.x-3.x

Thew’s picture

Thew commented
hass’s picture

hass commented

#3 is the patch for D7.

hass’s picture

hass commented
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +needs backport to 7.x-3.x

8.x-3.x is HEAD, it should be fixed first.

Thew’s picture

Thew commented
StatusFileSize
new 8.x-3.x-2834683-10.patch491 bytes

I'm not sure whether Drupal 8 has file upload button since it uses ajax.

However, I attached a patch file for 8.x-3.x, but I couldn't find the upload button.

And also, I'm not sure why you reorder the Log in button.

Thew’s picture

Thew commented
Status: Needs work » Needs review
hass’s picture

hass commented

The reordering is a code style bug. It allows to find the items easier as they are sorted than.

gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs review » Needs work

@hass, I guess that means that this needs work

Thew’s picture

Thew commented
StatusFileSize
new 8.x-3.x-2834683-14.patch758 bytes

Ok, fixed code style bug.

Thew’s picture

Thew commented
Status: Needs work » Needs review

  • markcarver committed ae8c409 on 8.x-3.x authored by Thew 
    Issue #2834683 by Thew, hass: Core image field has no colored upload...

  • markcarver committed 9c5514c on 7.x-3.x authored by hass 
    Issue #2834683 by Thew, hass: Core image field has no colored upload...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed
Issue tags: -needs backport to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.