Problem/Motivation

Theme Settings Docs are needed for Stable release.

Proposed resolution

Document it :)

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff-2746089-2-4.txt416 bytesrajeshwari10
#4 2746089-4.patch15.49 KBrajeshwari10
#2 docs_theme_settings_2746089-2.patch15.48 KBjorgediazhav

Comments

jorgediazhav created an issue. See original summary.

jorgediazhav’s picture

jorgediazhav commented
Status: Active » Needs review
StatusFileSize
new docs_theme_settings_2746089-2.patch15.48 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: jorgediazhav » Unassigned
Priority: Critical » Normal
Status: Needs review » Needs work

First, let me say thank you! This was, no doubt, not an easy task.

--

+++ b/docs/subtheme/settings.md
@@ -3,5 +3,156 @@
+To override a setting, open `./subtheme/subtheme.info.yml` and add the following:

Settings are located in ./config/install/THEMENAME.settings.yml, not the info file.

--

Also, I'm not entirely sure this is the best approach for documenting theme settings. It's a manual file and it can easily get stale rather quickly.

I would much rather find a way to generate this list automatically if possible. Maybe a grunt/drush command that reads the yaml file(s)? Or perhaps utilizing the plugin system somehow?

rajeshwari10’s picture

rajeshwari10 commented
Status: Needs work » Needs review
StatusFileSize
new 2746089-4.patch15.49 KB
new interdiff-2746089-2-4.txt416 bytes

Changed the location of the settings in subtheme.info.yml as per said n #3.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work
markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: DOCs : Theme Settings » Automatically document theme settings
Assigned: Unassigned » markhalliwell
Issue tags: -Documentation, -theme settings

  • markcarver committed f6f4490 on 8.x-3.x 
    Issue #2746089 by rajeshwari10, jorgediazhav, markcarver: Automatically...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajeshwari10’s picture

rajeshwari10 commented