Ensure jquery.once library is loaded when theme's bootstrap.js file is loaded

Isn't this a very specific case scenario? If you're not using the bootstrap.js, you might as well just add the bootstrap.css to another theme.

You could also just comment it out of the .info file with a ";"

The bootstrap_subtheme.info.starterkit (should be renamed to bootstrap_subtheme.info) already has the js declared under the section of "Method 1". You just have to take off one semicolin from each line so that your "Method 1" looks like this.

;;;;;;;;;;;;;;;;;;;;;
;; Scripts
;;;;;;;;;;;;;;;;;;;;;

scripts[] = 'bootstrap/js/affix.js'
scripts[] = 'bootstrap/js/alert.js'
scripts[] = 'bootstrap/js/button.js'
scripts[] = 'bootstrap/js/carousel.js'
scripts[] = 'bootstrap/js/collapse.js'
scripts[] = 'bootstrap/js/dropdown.js'
scripts[] = 'bootstrap/js/modal.js'
scripts[] = 'bootstrap/js/tooltip.js'
scripts[] = 'bootstrap/js/popover.js'
scripts[] = 'bootstrap/js/scrollspy.js'
scripts[] = 'bootstrap/js/tab.js'
scripts[] = 'bootstrap/js/transition.js'
; Disable BootstrapCDN if using Bootstrap source files in your sub-theme.
settings[bootstrap_cdn] = ''

When you turn on js aggregation, these files become equivalent to bootstrap.js. But here, you can comment out individual js features that you may not need.

Hi,

It doesn't look like this is the case, the file in the base theme sites/all/themes/bootstrap/js/bootstrap.js says:

"Provides general enhancements and fixes to Bootstrap's JS files."

It is not a file that belongs to the bootstrap library but it is a Drupal specific file from the boostrap module. It therefore is not the same with what you get from aggregating the sites/all/themes/bootstrap_subtheme/bootstrap/* files as these files are the original bootstrap library that has nothing to do with bootstrap.

@dimboz in #6 is correct. This is an enhancement JS file for Bootstrap -> Drupal integration. You're receiving this error because it sounds like the jquery.once library isn't loaded (for whatever reason). We'll likely need to patch the JS alter. Also it probably wouldn't hurt to rename the bootstrap.js file to drupal.bootstrap.js or something for clarity here.

Committed d0b92f9 to 7.x-3.x:

Issue #2149561 by Mark Carver | Jehu: Ensure jquery.once library is loaded when theme's bootstrap.js file is loaded.

Moving this to the 8.x-3.x branch as it has been committed to that branch. Making sure the fix gets tested in the Drupal 8 release.

I'm just moving this back to 7.x. If this needs re-evaluation in 8.x, create a new issue.

While moving the call for scripts-inclusion out of head in html.tpl.php, bootstrap.js is included too early, causing a JS error. I've been trying to patch bootstrap_js_alter in alter.inc, since this seems the culprit for this misbehavior, but miserably failing at it. Maybe someone can point me into the right direction to avoid the inclusion from happening too early.

ok, i found a solution for you guys using method 1: you do not really need the inclusion of bootstrap.js, like mentioned before by others. so i patched bootstrap_js_alter(), simply disabling the inclusion of bootstrap.js. Everything works great now.

This just bit me when using the latest snapshot of 7.x-3.x to create a sub-theme of Bootstrap, so it does not look like it has been fixed.

I am using the "less" starter kit (previously known as "method 1").

It looks like jquery.once.js is loaded on my site:

<script src="http://.../misc/jquery.once.js?v=1.2">

but that does not seem to be enough - so I am changing the title.

Patching bootstrap_js_alter() to not include bootstrap.js (as suggested in #15) fixed it for me.

I also think the Drupal theme's bootstrap.js should be renamed drupal.bootstrap.js (as suggested in #7) for clarity. It is awkward for debugging that it has the same file name as the main bootstrap library.

@gisle, please create a new issue and reference closed ones. Hi-jacking existing closed issues makes it difficult to track when something has already been committed.

The += operator doesn't work reliably on all configurations. The attached patch proposes using array_replace() instead. If there are other users running into the following error, let's reopen this and rework the committed patch.

PHP Fatal error: Unsupported operand types in /sites/all/themes/bootstrap/includes/alter.inc on line 330

Similar issue with Bootstrap 7.x-3.6 js errors "TypeError: $context.find(...).once is not a function" causing other js not to load. Loading jquery 1.9 with jquery_update (1.9 or higher required). Load order looked fine. Added...

exclude[js][] = 'sites/all/themes/bootstrap/js/misc/_vertical-tabs.js'

to .info file to remove error. A blunt solution until this issue gets sorted.

I have same issue and my solution is exclude bootstrap.js on my custom theme.