D8 Port - Bootstrap

I'm sure there will be, but I think we're still focused on getting a solid release out for D7. Marking this as minor for the time being.

Marking appropriately.

Alright, I've started the initial port to D8. For anyone wanting to look/test there is now an 8.x-2.x branch.

Please keep in mind that this is "experimental" at this time as there are a lot of #2004872: [meta] Theme system architecture changes still going on in core.

Known issue: #2030457: Warning: Missing argument 3 for template_preprocess() for theme functions overridden by templates

Also, this issue should be the main issue for collecting meta issues about the port. If you find a bug, please create a new issue with a patch. Thanks!

Moving this to postponed again for a bit (probably until after BADCamp).

As 7.x-2.x is currently deprecated, we shouldn't port it to #D8.
Should we stick with the naming schema and create 8.x-3.x?

Yes. I don't want to do this yet until 7.x-3.0 is released though. I am also waiting until #2035055: Introduce hook_theme_prepare[_alter]() and remove hook_preprocess_HOOK() is in core to _really_ start working on it.

spell

@Mark

Quick thanks to all of the devs who worked on the 7.x version of this theme, I use it for most of my projects. I am starting to lay the ground work for NVIDIA to adopt Drupal 8, and part of that includes utilizing Bootstrap 3 in those projects. I'm going to start taking a stab at a Drupal 8, Bootstrap 3 version of this theme so I thought I would poke my head in here and ask a couple of questions.

1. In creating a 8.x-3.x branch, would it be better to branch off of 8.x-2.x or 7.x-3.x? I originally started off of the 8.x-2.x branch but now that 7.x-3.0 is out, it occurred to me that it might be better to go off of the 7.x-3.x branch to preserve all the work you've done on bringing BS3 into Drupal, as the work to convert a 7.x theme to an 8.x theme isn't too difficult (just time consuming).

2. I'm currently just working off of a local branch, any plans to open a 8.x-3.x branch now that 7.x-3.0 has been released?

3. Any general thoughts, ideas, etc that you've been going over on moving to Drupal 8? Things that you want to redo, add, remove etc? If you are planning any IRC meetups or something like that, it wouldn't mind joining in.

I've gone ahead and created the 8.x-3.x branch off the latest 7.x-3.x (which means it is currently completely for D7 and will not work for D8). Please create new issues/patches against the 8.x branch to help get this working. As far as a "timeline" of when this will be completed, core doesn't even have a release date... so "when it's ready".

In regards to question #3, there's no "set" planning in IRC, but you're more than welcome to join #drupal-bootstrap. I'm not always there, but you can leave me Druplicon tells if needed.

Perfect, I'll start making issues/patches off of that branch. Thanks Mark!

Hey guys,

I'm going to be going pretty full bore on the Drupal 8 port as NVIDIA requires it for some upcoming projects later this year. I've got a couple of big patches that are ready for review, the first of which actually gets the 8.x-3.x branch somewhat useable and are awaiting review.

• #2190877: Replace variable_*(), theme_*_variable() with D8 CMI and added excludes to config.
• #2198905: Update Bootstrap to use the simplified names of "element-x" helper classes

I know the maintainers have busy schedules and are focused on 7.x-3.x issues so I wanted to offer to help maintain the 8.x-3.x branch. Before I can write too many more patches the above patches need to be committed as they make fairly large changes, and given the good amount of patches that have been committed to the 7.x-3.x branch since 8.x-3.x a merge or cherry-pick is probably in order. As it stands now, the first patch means that the second patch would need to be rerolled to apply cleanly after patch 1 is committed.

Anyways, let me know how I can best help!

@ryan.armstrong, thank you for all your help! Yes, we'll need to merge in the changes from 7.x-3.x. Unfortunately, given the huge difference in file structure and APIs, cherry picking will not work. We'll need to manually go through and apply the changes. Once 8.x-3.x is caught up, we can make it HEAD. Then we can follow the same practice in core where we first check to see if the issue exists in 8.x, patch it and then work on 7.x. I'm not opposed to you being the maintainer for 8.x for the moment. It would certainly help if you could focus on that and I focus on 7.x until I have the time again to focus on 8.x. @wundo, would you mind making him a maintainer? @ryan.armstrong, would you mind contacting me through my form with your skype so we (@wundo possibly too) can chat about some logicists regarding workflow. Thanks!

Ryan, welcome to the maintainers team ;)

Thanks wundo! I'll get right to work ;)

Closing this since Drupal 8 development is in full bore now with a full issue queue. This topic will no longer be updated. Please open a new issue for new tasks or bugs using the 8.x-3.x version tag. Thanks!