The recent change with the implementation of allowing a bootstrap CDN is all fine and good, but I do not think it is wise to put the "else" statement of using the manually downloaded bootstrap library in the theme folder to be hard-coded in theme.inc.

The .info file is where where people assume that css and js files are added by default, and rightfully so. More advanced users may want to change how these files are included (placing the library outside of theme folder, using LESS files instead, etc.) and hard-coding the "default" method of including these files within theme.inc I think is not the best practice, as you have to search for how the files are even being included in the first place. Can we instead have the CDN "else" statement in theme.inc simply refer back to the locations set in the .info?

Comments

frankbaele’s picture

you make a valid point, maybe bootstrap should just unset the all the bootstrap css if its activated. or shouldnt do anything just at the css

andregriffin’s picture

Yes, I think if you could try and unset the .info's css/js and then add via CDN if activated, that would make sense. This will also fix the sort/weight problem from the other issue, as the order of inclusion in the .info is honored in the markup.

frankbaele’s picture

StatusFileSize
new2.59 KB
frankbaele’s picture

Status: Active » Needs review
frankbaele’s picture

btw could you take a look at http://drupal.org/node/1857358

andregriffin’s picture

StatusFileSize
new2.75 KB

Looks great. Here's a slight modification that ensures the CDN css is added in the right order/group (theme layer, after modules, before style.css)

frankbaele’s picture

commit this to dev ?

andregriffin’s picture

Seems okay to me. Thanks

frankbaele’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

clarification