Closed (fixed)
Project:
Block Refresh
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Oct 2012 at 18:00 UTC
Updated:
20 Jan 2015 at 01:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
adinxy commentedSame problem. I am using Zen theme 7.x-5.1
I found that the block_refresh.js require the class .content but Zen theme omitted this class in block.tpl.php
Just re-use drupal core block.tpl.php
Comment #2
mermemladeK commentedWhat is the state on this issue? I was considering this module but I use Zen...
Comment #3
tripper54 commented@mermemladek , the module currently does not work with Zen 5. adinxy's suggested fix in #1 will work. Going forward I think I'll add explicit support for Zen as it's such a popular theme.
Comment #4
tripper54 commentedComment #5
tripper54 commentedComment #6
tripper54 commentedPreliminary support for Zen (and other themes that don't create a "content" container in their block template) in attached patch.
I'd be interested in reviews before committing.
Comment #7
tripper54 commentedComment #8
jayha commentedWhere do you apply the patch block_refresh_zen-1816868-6.patch ?
Comment #9
tripper54 commentedThanks for having a look!
Apply to the patch to the latest 7.x-2.x dev, see https://drupal.org/project/block_refresh/git-instructions
The patch should apply cleanly, any problems let me know.
Comment #10
sbilde commentedI can confirm that the patch in #6 works with the Bootstrap 7.x-3.0 theme as well.
Comment #11
tritof commentedThanks to #6 and #10, I found the solution to override the block.tpl.php file by adding the
<div class="content">after<section>and it works (Bootstrap 7.x-3.0)Comment #12
tripper54 commented@Tritof, so the patch in #6 did not work for you?
Comment #13
tritof commentedyes it worked. Thanks
Comment #14
tripper54 commentedGreat, thanks for getting back to me Tritof.
I think this can be marked as RTBC now.
Comment #16
tripper54 commentederp, looks like it needs re-rolling. I'll work on this on the weekend.
Comment #17
tripper54 commentedre-rolled for latest dev.
Comment #18
tripper54 commentedComment #20
tripper54 commentedAfter 18 months, finally a working patch committed! Thanks to everyone for your help on this issue.
Comment #22
tritof commentedHey, I am really (really) sorry. I am retesting the patch because I still have an issue with the block refresh and the manual function. I just notice a strange behavior with the patch :
1/ It appears only when a drupal.behavior is triggered in the page (not related to the patch, the version without patch has the same bug)
2/ First click on refresh is ok
3/ Second click on refresh reload the entire page and so the refresh manual button disappear because back to 1/ (related to the patch because the version without the patch has not this bug).
I don't want to reopen it because it was about Zen theme and I am testing with Bootstrap. Just for info.
Comment #23
tripper54 commented@tritof, can you please open another issue? It sounds like there are bug(s) that need investigating.
thanks!
Comment #24
fritzpadilla commentedI can verify that the above path is included in version 7.x-2.3 but DOES NOT work in Zen 7.x-5.4. I can see that the JS is executing but the content of the block is never updated.
Comment #25
tripper54 commentedHi fritzpadilla,
I just confirmed block refresh 7.x-2.3 works with zen 7.x-5.4
I did this with a fresh install of drupal, zen 5.4 and block_refresh 2.3. Confirmed that the block_refresh_test module does indeed refresh manually and automatically (timed).
So your issue is not related to block_refresh/zen interoperability, and this issue.
If you continue to have problems, could you please open a new issue and include steps to reproduce the problem?
thanks!
Comment #26
Drupa1ish commentedNot working with Omega theme 7.x-3.1
Comment #27
tripper54 commented@EuroDomenii , this issue is for Zen theme compatibility, and is now fixed. Could you log your bug in a new issue thread?
thanks!
Comment #28
Drupa1ish commentedSorry, false alarm ... Some rogue custom script was to blame! Works perfectly with Omega 7.x-3.1