Hi Jeni,

How's it going down there in Brighton? Hope you've settled comfortably into your new pad.

This module is kinda cool. Simpler than skinr gets my vote :-)
I was thinking of doing something similar, to predefine classes for menu_attributes module.

Are you planning to make this a full project, or contributing changes to the main block_class project?
If you put in a full-project application, let me know and I'll be sure to review it.

Comments

klonos’s picture

Title: Nice module! What're your plans? » Initial release of Block Class Select module? / Current status / What needs testing ...a.k.a. "Are we there yet?"
Issue summary: View changes

...I too am curious to see if this will become a full project of its own or whether it will be merged back to Block Class.

klonos’s picture

jeni_dc’s picture

Thanks for your interest in this! I had basically put this on hold since I was informed about the Block Class Styles module, which essentially does the same thing. There are differences in implementation and features, though, between the two modules, but I thought a release of this would essentially be duplicating efforts.

There was some talk of merging this with Block Class, with my last comment here: https://drupal.org/comment/7751817#comment-7751817

I'm more than happy for this to go forward alongside Block Class Styles, but I don't think this module would get approval due to some feature duplication. I don't have any full projects yet on d.o., so a review would be necessary.

There is also an issue, #1940142: Classes Remain after Unselecting All Classes, which needs to be resolved before a full release anyway.

So at the moment, I'm still basically treating this as on hold.

klonos, if you'd like to check out Block Class Styles and let me know if that's what you're looking for, or if you would prefer the way this module is done, your feedback would be great.

marcoka’s picture

thank you for pointing me to the block class styles module.

xenophyle’s picture

Hi Jeni,

This module does exactly what I need and had been planning to implement for a while now. I don't see how it is the same as Block Class Styles, since it is really important for a developer to be able to specify classes that a client site admin doesn't need. There are many cases where I want to apply styles to certain blocks, in particular blocks generated by modules, that would never be used by the client. I also want to keep the set of classes visible to the client limited.

This module is so simple I hate to suggest modifying it to be an add-on for Block Class Styles, but maybe that would make sense.

Thanks!

xenophyle’s picture

Version: » 8.x-1.x-dev
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.