Fixed
Project:
Block Class
Version:
3.1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Oct 2026 at 23:03 UTC
Updated:
9 Oct 2026 at 00:07 UTC
Jump to comment: Most recent
Problem/Motivation
Currently, the module uses the default Gitlab CI templates for the PHPSTAN job:
https://git.drupalcode.org/project/gitlab_templates/-/raw/default-ref/as...
With the lowest rule level: 0, which only does very basic PHP code validation:
https://git.drupalcode.org/project/block_class/-/blob/3.1.x/phpstan.neon...
We would like to enforce a stricter validation of the module's code base, see the PHPSTAN rules levels:
https://phpstan.org/user-guide/rule-levels
Steps to reproduce
Run locally:
./vendor/bin/phpstan analyze web/modules/contrib/block_class/ -l 10
Many errors will be displayed.
Proposed resolution
Fix all validation errors and add a phpstan.neon configuration file to set the rule level to 10 for the job on Gitlab CI.
Additional change: Extend phpcs quality coverage with the DrupalPractice ruleset.
Similar issues
Issue fork block_class-3629522
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
dydave commentedQuick follow-up on this issue:
The goal of this MR and issue in general is to try to increase as much as possible code quality control coverage to provide a stricter and tighter frame for code generation with AI.
The purpose of raising the validation level of the phpstan job to 10 is to enforce a certain standard of code quality production.
Most of the work in the MR was assisted with AI which made code changes and fixed errors iteratively, with approval, until all errors were fixed.
Then I had a few iterations as well to fix the Gitlab CI configuration for the
mglaman/phpstan-drupalextra rules.phpstan.neonplusphpstan-strict.neonmax(10)phpstan.neonplusphpstan-strict.neonmax(10)phpstan.neonplusphpstan-strict.neonmax(10)phpstan.neononlymax(9)Added also PHPCS config file to explicitly require the
'DrupalPractice'ruleset, which adds 40 extra sniffs.After doing some tests locally and since all the jobs were passing 🟢, I went ahead and merged the changes above at #3. 🥳
Basically, the idea behind all this is to increase as much as possible the quality controls though the Gitlab CI quality gates in order to be as "safe" as possible maintaining the code base with AI.
At this point, we have greatly increased the checks for PHPCS and PHPSTAN, plus, we also have Gitlab Advanced Security, Semgrep and Secret Detection...
We could probably consider this is a pretty good example or template of module's pipelines configuration, that could maybe be reused for other modules.
Since all the work to be carried in this issue should have been completed at this point, marking as Fixed, for now.
Thanks in advance!