Although the module implements bitcache_hook_info() and defines triggers, the actual trigger implementation is not finished.

Attached patch ensures that the actions are fired on the selected triggers.

CommentFileSizeAuthor
b.patch2.7 KBmiglius

Comments

miglius’s picture

miglius commented
Title: Triggers does not fire actions » Triggers do not fire actions
Arto’s picture

Arto commented
Assigned: Unassigned » Arto
Issue tags: +bitcache_hook_info
miglius’s picture

miglius commented

Typo - casting should be to object type in the following line:
+ $object = (array) array('id' => $id);

Arto’s picture

Arto commented
Issue tags: +6.x-1.0-beta2
Arto’s picture

Arto commented
Status: Needs review » Needs work

A problem with the patch is that bitcache.inc should not contain any Drupal-specific code, in order that it can be reused in other non-Drupal PHP projects.

I will refactor the code to provide event triggering in the repository class, which the Drupal module can then subclass implementing module_invoke_all().

Arto’s picture

Arto commented
Status: Needs work » Fixed

Changeset [180380] implements this in a way that preserves bitcache.inc's suitability for non-Drupal use.

Please test and report any problems... did you have a File Framework use case for this functionality, already?

miglius’s picture

miglius commented

I thought that bitcache.inc should not contain any Drupal-specific code, but put it there just to show what is expected. Your patch should fix the issue. So far I don't have any specific use case, just was playing around and noticed that the cron was not triggered even was configured so.

Status: Fixed » Closed (fixed)
Issue tags: -bitcache_hook_info, -6.x-1.0-beta2

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +bitcache_hook_info, +6.x-1.0-beta2

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.