When viewing the differences between two node revisions I get the following warning:

warning: Parameter 1 to biblio_diff() expected to be a reference, value given in /drupal/includes/module.inc on line 476.

CommentFileSizeAuthor
#1 biblio-diff-2345777-1.patch796 bytesosopolar

Comments

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Status: Active » Needs review
StatusFileSize
new biblio-diff-2345777-1.patch796 bytes

Objects are passed (and assigned) by reference. No need to use address of operator. This patch removes the & operator (as in other implementations of hook_diff()).

This results in the following warnings:

    warning: explode() expects parameter 2 to be string, array given in /home/drupalpro/websites/tubaf.ls/sites/default/modules/biblio/biblio.module on line 2110.
    warning: explode() expects parameter 2 to be string, array given in /home/drupalpro/websites/tubaf.ls/sites/default/modules/biblio/biblio.module on line 2111.

The warnings comes from the biblio-keywords, which is an array not a sting. This patch fixes this too.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.