The ['options'] array is empty if you create a set of Quicktabs programatically. Also, in some cases, the $key element is not numerical - so using that as a value in the tab items and tab panes doesn't work.

CommentFileSizeAuthor
#6 1795944-6.bh_bootstrapextras.patch644 bytesjrb
#2 bh_bootstrapextras-1795944-2.patch2.05 KBavr
#1 bh_bootstrapextras-1795944-1.patch2.04 KBavr

Comments

avr’s picture

avr commented
Status: Active » Needs review
StatusFileSize
new bh_bootstrapextras-1795944-1.patch2.04 KB

Patch attached for both issues.

avr’s picture

avr commented
StatusFileSize
new bh_bootstrapextras-1795944-2.patch2.05 KB

Previous patch would break options from the Quick Tabs interface.

  • shelane committed ad80257 on 
    git commit -m 'Issue #1795944 by avr: Options not present when creating...
shelane’s picture

shelane
Primary language English
commented
Assigned: Unassigned » shelane
Issue summary: View changes
Status: Needs review » Fixed

Fixed in 1.1 release.

shelane’s picture

shelane
Primary language English
commented
Status: Fixed » Closed (fixed)
jrb’s picture

jrb
he/him
Primary language English
Location Raleigh-Durham Area, NC, USA
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 1795944-6.bh_bootstrapextras.patch644 bytes

This update seems to have missed one line of the patch in #2. After updating (without patching), I'm getting this:

Notice: Undefined index: tabtype in QuickBhBootstrapTabs->render() (line 51 of sites/all/modules/contrib/bh_bootstrapextras/bh_bootstrapquicktabs/QuickBhBootstrapTabs.inc).

Patch attached.

  • shelane committed 90e419d on 7.x-2.x authored by jrb 
    Issue #1795944 by avr, jrb: Options not present when creating quicktabs...
shelane’s picture

shelane
Primary language English
commented
Status: Needs review » Fixed

  • shelane committed 476cdba on 7.x-1.x authored by jrb 
    Issue #1795944 by avr, jrb: Options not present when creating quicktabs...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

shelane’s picture

shelane
Primary language English
commented

This patch has been applied to the 1.x branch, but was removed from the 2.x branch due to name changes and defaults being set. It is recommended that you update to the 2.x branch. Also, this module will no longer be supported going forward. For future updates, install the Bootstrap Quicktabs module. It is the 2.x branch of this module renamed.