Problem/Motivation

In the Social block, link for Facebook uses X icon

Steps to reproduce

In a sub-theme of Belgrade (where I do NOT have the icons folder) in the themes/custom folder

Proposed resolution

tried to make in Belgrade contrib theme folder tu run
npm run icons-sprite
clear cache
BUT not solved anything

problem is that scss is showing .menu--solcial [href*=x] instead of Facebook

PICTURE 2 : If ever I make scss elements inactive it's ok

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
capture 234.jpg524.43 KBstephane bouillet
capture 233.jpg702.67 KBstephane bouillet

Issue fork belgrade-3580059

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

stephane bouillet created an issue. See original summary.

majmunbog made their first commit to this issue’s fork.

majmunbog opened merge request !88

majmunbog’s picture

majmunbog commented

@stephane bouillet Thanks for pointing this out. This bug is caused by having "x" in the Facebook link. The social icon map includes pattern "x", which compiles to .menu--social [href*=x] and will match lots of unrelated URLs.

I tightened all Belgrade social icon URL patterns from broad substrings (like facebook, medium, google) to domain-based matches (like facebook.com, medium.com, google.com, etc.), so they won’t accidentally match unrelated links.

majmunbog’s picture

majmunbog commented
Status: Active » Needs review

majmunbog’s picture

majmunbog commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.