Currently the datafiles cache contains file names from all sites on the server, regardless of the value of bawstats_admin_access.

Also, there are some errors in bawstats.data.inc, spotted in this issue: #3531406: Deprecated function: Implicit conversion from float 19.5 to int loses precision.

This patch (1) incorporates these changes; (2) prevents files from other sites entering the cache when bawstats_admin_access=0; and (3) clears datafiles and servers caches if bawstats_admin_access is changed.

Comments

egfrith created an issue. See original summary.

  • egfrith committed 96a77816 on 2.x 
    Issue #3531663 by egfrith, bisonbleu: data files caching fixces and...
egfrith’s picture

egfrith commented
Title: data files caching fixces and improvments » data files caching fixes and improvements
egfrith’s picture

egfrith commented
Status: Needs work » Needs review
bisonbleu’s picture

bisonbleu commented
Status: Needs review » Reviewed & tested by the community

I've been running the latest dev version for a few days and I'm not seeing any regressions and/or errors. But I'm not exactly sure how one would validate this… ?

Setting to RTBC. Feel free to change status if required.

egfrith’s picture

egfrith commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing this patch @bisonbleu - now closing issue with credit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.