The footer styling is a bit of mess. It has things like #footer-wrapper #footer and other too-specific rules.

We can simplify the rules pretty easily.

CommentFileSizeAuthor
#4 footer-rules-cleanup-845940-4.patch1.2 KBjohnalbin
#1 footer-rules-cleanup.patch2.76 KBjohnalbin

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: System menu blocks don't get the same styling as menu module blocks » CSS rules for footer styling needs cleanup
Status: Active » Fixed
StatusFileSize
new footer-rules-cleanup.patch2.76 KB

Here's the styling I just committed.

jensimmons’s picture

jensimmons commented
Status: Fixed » Needs work

Yeah, this patch is awful. It totally messes up the footer. Please revert the whole thing.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Assigned: Unassigned » johnalbin

Whoops. forgot #footer-columns is in #footer-wrapper, but not in #footer. Testing Bartik without filling up all regions-- Bad JohnAlbin!

I'm trying to commit this, but CVS is down. :-p

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs work » Fixed
StatusFileSize
new footer-rules-cleanup-845940-4.patch1.2 KB

I've reverted the original patch and committed this much gentler patch. :-D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.