patch fixes documentation inconsistency in template.php file

CommentFileSizeAuthor
#2 bartik-theme-2.patch1.51 KBrstamm
bartik-theme.patch1.54 KBrstamm

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Needs work

template_preprocess_HOOK? No, that's what modules implement. Its confusing, I know. See http://api.drupal.org/api/function/theme/7

rstamm’s picture

rstamm commented
Status: Needs work » Needs review
StatusFileSize
new bartik-theme-2.patch1.51 KB

oic. patch updated.

bleen’s picture

bleen commented
Status: Needs review » Needs work

@Ralf take a look at Garland's template.php to see how preprocess functions should be documented

rstamm’s picture

rstamm commented

bartik_process_page function is an implementation of THEME_process_HOOK.
and simular to hook implementations, it is rather standard and does not require more explanation.

and it's also easier for modules like the api module, to generate links to its reference.

did not find any documentation in http://drupal.org/node/1354, nor threads. maybe Jennifer or John can open one for discus.

rstamm’s picture

rstamm commented
Status: Needs work » Needs review

let's wait for other opinions.

rstamm’s picture

rstamm commented

http://groups.drupal.org/node/69823

bleen’s picture

bleen commented
Status: Needs review » Needs work

I have no problem with coming up with a standard way of documenting this ... but the patch you have in #2 actually has

THEME_preprocess_HOOK()

...neither THEME nor HOOK are placeholders in that patch. Clearly we can't have comments like that.

jensimmons’s picture

jensimmons commented
Status: Needs work » Closed (won't fix)

Closing, now that Bartik is in core.