Look at the patch at http://drupal.org/node/683026#comment-2981720 in #683026: Add a new theme to D7 core: Bartik using Dreditor, I can see spacing errors. Those need to be fixed up.

CommentFileSizeAuthor
#4 spacing-802544-4.patch5.36 KBjohnalbin
#3 kill-red-dreditor-warnings-802544.patch5.91 KBjohnalbin

Comments

jensimmons’s picture

jensimmons commented
Assigned: Unassigned » jensimmons

I'm going to start on this.

jensimmons’s picture

jensimmons commented
Assigned: jensimmons » Unassigned

Ok, I'm not going to do it right now.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Fix up spacing errors. » Fix up spacing errors
Status: Active » Fixed
StatusFileSize
new kill-red-dreditor-warnings-802544.patch5.91 KB

Here's the patch I just committed. Dreditor shows green on a Bartik test patch I rolled.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
StatusFileSize
new spacing-802544-4.patch5.36 KB

Follow-up patch committed too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.