Distinguish between different types of lists, i.e. theme_menu(), theme_links(), theme_item_list().

Jen posting screenshot.

Comments

heather’s picture

I was about to add an issue for this, but I wonder if it's related to the above.

This is the problem:
Only local images are allowed.
Only local images are allowed.

The blocks treat bullets differently. The bullets are not of the same type and alignment within the block, as with Navigation. I'd be happy to write a patch, just wonder what is the best solution.

Especially because in the User login block, The OpenID module removes the bullet. I also question whether these are list items in a meaningful sense. I understand the convenience for accessibility purposes, but visually, I do not think these are really a list? Isn't this one of the first things people do when they customize a Drupal theme: fix the login block? Hm..

This is what Stark shows us:

Only local images are allowed.

Jeff Burnz’s picture

Status: Active » Needs review
StatusFileSize
new1.74 KB

First crack at a patch - this goes a little further than suggest above, styling lists in content also since ol/ul indentation was quite different, and the triptych lists were off also.

Jeff Burnz’s picture

StatusFileSize
new1.96 KB

Rerolled, added missing RTL styles.

bleen’s picture

Status: Needs review » Needs work
+ul.menu li {
+margin:0;
+}
+.region-content ul,
+.region-content ol {
+  margin: 1em 0;
+  padding: 0 0 0.25em 2.5em;  /* LTR */
+}
+.item-list ul li {
+margin: 0;
+padding:0.2em 0.5em 0 0;  /* LTR */
+}
+ul.tips {
+padding:0 0 0 1.25em;  /* LTR */
+}

Missing white-space

Jeff Burnz’s picture

Status: Needs work » Needs review

All the CSS files need a white space review, lets stick to the scope of the issue here (the patch is consistent with the current CSS formatting for Bartik).

White space clean-up can be another issue, right now we need browser testing.

jensimmons’s picture

Actually, Bartik has gotten quite a lot of whitespace review and work. So to the extent that we can, let's check all the new changes as we go forward.

I'll edit this patch before I apply it to fix the spacing.

jensimmons’s picture

I can't apply this patch. There's something wrong with it.

It needs to be rerolled, with cleaned up spacing.

jensimmons’s picture

Jeff -- make your patches from inside the Bartik directory. You've got Bartik in sites/all/themes, and that's messing things up. We are working on it in themes/.

And or ask in #drupal-contribute for help. I'm still pretty new to all this CVS Drupal stuff too.

Meanwhile, I jammed this patch through! Fingers crossed....

jensimmons’s picture

Status: Needs review » Fixed

Committed.

Jeff Burnz’s picture

Yeah, sorry, I was rolling in a hurry and knocked them out from the project root (Eclipse project), future ones will be bang on.

jensimmons’s picture

Cool. Awesome work Jeff :D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.