Closed (fixed)
Project:
Bartik
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2010 at 02:33 UTC
Updated:
12 Apr 2010 at 01:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
heather commentedI was about to add an issue for this, but I wonder if it's related to the above.
This is the problem:


The blocks treat bullets differently. The bullets are not of the same type and alignment within the block, as with Navigation. I'd be happy to write a patch, just wonder what is the best solution.
Especially because in the User login block, The OpenID module removes the bullet. I also question whether these are list items in a meaningful sense. I understand the convenience for accessibility purposes, but visually, I do not think these are really a list? Isn't this one of the first things people do when they customize a Drupal theme: fix the login block? Hm..
This is what Stark shows us:
Comment #2
Jeff Burnz commentedFirst crack at a patch - this goes a little further than suggest above, styling lists in content also since ol/ul indentation was quite different, and the triptych lists were off also.
Comment #3
Jeff Burnz commentedRerolled, added missing RTL styles.
Comment #4
bleen commentedMissing white-space
Comment #5
Jeff Burnz commentedAll the CSS files need a white space review, lets stick to the scope of the issue here (the patch is consistent with the current CSS formatting for Bartik).
White space clean-up can be another issue, right now we need browser testing.
Comment #6
jensimmons commentedActually, Bartik has gotten quite a lot of whitespace review and work. So to the extent that we can, let's check all the new changes as we go forward.
I'll edit this patch before I apply it to fix the spacing.
Comment #7
jensimmons commentedI can't apply this patch. There's something wrong with it.
It needs to be rerolled, with cleaned up spacing.
Comment #8
jensimmons commentedJeff -- make your patches from inside the Bartik directory. You've got Bartik in sites/all/themes, and that's messing things up. We are working on it in themes/.
And or ask in #drupal-contribute for help. I'm still pretty new to all this CVS Drupal stuff too.
Meanwhile, I jammed this patch through! Fingers crossed....
Comment #9
jensimmons commentedCommitted.
Comment #10
Jeff Burnz commentedYeah, sorry, I was rolling in a hurry and knocked them out from the project root (Eclipse project), future ones will be bang on.
Comment #11
jensimmons commentedCool. Awesome work Jeff :D