Problem/Motivation

Be ready for Drupal 9.

Proposed resolution

  • [ ] Create a patch which follow the Gabor documentation: http://hojtsy.hu/blog/2018-dec-17/how-automate-testing-whether-your-drup... to expose potential code flaws
  • [ ] Test the module using umami and the Upgrade Status module
  • [ ] Add drupal-check as a dev-dependency, update the DEVELOPPING.md file (section [## 🚔 Check Drupal coding (...) practices) with the new drupal-check feature, update the scripts/hooks/post-commit file with the drupal-check command

Remaining tasks

CommentFileSizeAuthor
#21 3090749-21.patch2.79 KBwengerk
#17 3090749-16.patch15.59 KBwengerk
#17 interdiff-3090749-15-16.txt283 byteswengerk
#16 interdiff-3090749-14-15.txt4.57 KBwengerk
#16 3090749-15.patch15.27 KBwengerk
#15 3090749-14.patch11.88 KBwengerk
#15 interdiff-3090749-13-14.txt523 byteswengerk
#14 3090749-13.patch11.85 KBwengerk
#14 interdiff-3090749-12-13.txt9.87 KBwengerk
#13 3090749-12.patch662 byteswengerk
#11 3090749-11.patch13.94 KBwengerk
#11 interdiff-3090749-10-11.txt292 byteswengerk
#10 3090749-10.patch13.78 KBwengerk
#10 interdiff-3090749-09-10.txt1.11 KBwengerk
#9 3090749-09.patch14.47 KBwengerk
#8 3090749-08.patch12.01 KBwengerk
#7 3090749-07.patch8.59 KBwengerk
#6 3090749-06.patch8.15 KBwengerk
#5 3090749-05.patch7.81 KBwengerk
#4 3090749-04.patch7.79 KBwengerk
#2 3090749-02.patch662 byteswengerk

Comments

wengerk created an issue. See original summary.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Active » Needs review
StatusFileSize
new 3090749-02.patch662 bytes

Let's test the patch

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Issue summary: View changes
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-04.patch7.79 KB

Let's test the new patch

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-05.patch7.81 KB

Let's rerun the patch with the proper core_version_requirement: ^8.7.7 || ^9 line

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-06.patch8.15 KB

let's tests it again

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-07.patch8.59 KB

Fix the `Drupal\Tests\taxonomy\Traits\TaxonomyTestTrait`

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-08.patch12.01 KB

remove deprecated file_valid_uri and entity_get_display

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-09.patch14.47 KB

remove deprecation of setExpectedException

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090749-09-10.txt1.11 KB
new 3090749-10.patch13.78 KB

rerolled patch

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090749-10-11.txt292 bytes
new 3090749-11.patch13.94 KB

Add the new required protected $defaultTheme = 'stark'; as explain here: https://www.drupal.org/node/3083055

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Version: 8.x-4.x-dev » 8.x-5.x-dev
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-12.patch662 bytes

New patch for branch `8.x-5.x` of Bamboo Twig.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090749-12-13.txt9.87 KB
new 3090749-13.patch11.85 KB

Fix Drupal 9 deprecation from peer-dependency (Twig and Symfony Mime updates)

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090749-13-14.txt523 bytes
new 3090749-14.patch11.88 KB

Here a fixed version of previous patch

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-15.patch15.27 KB
new interdiff-3090749-14-15.txt4.57 KB

The latests warning are from a vendors (which is deprecated, another issue will be created to remove it soon).

Let's add a last patch to make sure tests pass for Drupal 8.8+ (Drupal 9 included).

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090749-15-16.txt283 bytes
new 3090749-16.patch15.59 KB

Fix for Drupal 8.8 by using symfony/mime as peer-dependency.

  • wengerk committed 2e1c3d0 on 8.x-5.x 
    Issue #3090749 by wengerk: Drupal 9 Readiness
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090749-21.patch2.79 KB

new breaking changes with PluralTranslatableMarkup::DELIMITER -> Drupal\Component\Gettext\PoItem::DELIMITER.