Problem/Motivation

When an email is excluded as a sensitive email it is never sent because in inc/hooks.php there $message['send'] = FALSE; which prevent the email to be sent without honoring the $send parameter of the MailManager.

Proposed resolution

We could simply remove the offending line.

CommentFileSizeAuthor
#6 interdiff-3168259-05-06.txt2.86 KBwengerk
#6 3168259-06.patch2.9 KBwengerk
#6 3168259-06--must-fail.patch1.33 KBwengerk
#5 3168259-05.patch2.33 KBwengerk
#5 3168259-05--should-fail.patch2.33 KBwengerk
#3 backerymails-sensitive_emails_are_not_sent-3168259-3.patch424 bytesaerzas

Comments

Aerzas created an issue. See original summary.

aerzas’s picture

aerzas commented
Title: Excluded sensitives e-mails are not sent » Excluded sensitive e-mails are not sent
aerzas’s picture

aerzas commented
StatusFileSize
new backerymails-sensitive_emails_are_not_sent-3168259-3.patch424 bytes

Here is the proposed patch.

aerzas’s picture

aerzas commented
Status: Active » Needs review
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3168259-05--should-fail.patch2.33 KB
new 3168259-05.patch2.33 KB

Many thanks for your patch !!!

Sorry to no giving you any answer before, I was pretty busy with all that covid stuff around here.
Anyway, here is another patch with a tests. And a Test only (should-fail) file to ensure everything works fine and we properly fix an issue.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3168259-06--must-fail.patch1.33 KB
new 3168259-06.patch2.9 KB
new interdiff-3168259-05-06.txt2.86 KB

... would be better with the proper tests ...

  • wengerk committed 277b3ce on 8.x-2.x 
    Issue #3168259 by wengerk, Aerzas: Excluded sensitive e-mails are not...
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.