Autosave does not operate when CKeditor is maximized.

Thanks for this neat, efficient module.

CommentFileSizeAuthor
#6 autosave_6.x-2.11_CKEDITOR4.patch1.07 KBvgalindus
#4 autosave.patch586 bytesvgalindus

Comments

liquidcms’s picture

liquidcms commented
Status: Active » Postponed (maintainer needs more info)

is this with stand-alone CK or with wysiwyg?

the former is not officially supported. for the latter; please provide a patch if that is the case you are using.

jvieille’s picture

jvieille commented
Category: bug » feature

Stand-alone CK
I would suggest that this module be supported as it is one of the most popular and offers more features than through wysiwyg.
So, not a bug, rather happy it works so well with an unsupported editor...

Thanks

liquidcms’s picture

liquidcms commented

well, as i said, CK stand alone is not officially supported (and never will be) but a patch was committed ages ago that allows it to work with CK stand alone. if you want to contribute a patch to fix the full screen issue i will consider committing it.

vgalindus’s picture

vgalindus commented
StatusFileSize
new autosave.patch586 bytes

Hi! I have run into the same issue and this small change seems to fix the problem. It's only tested with wysiwyg module.
BTW I have seen some issues regarding autosave doesn't works with CKeditor 4 and it does for me v4.2

BR

jvieille’s picture

jvieille commented

This patch does not seem to apply to the autosave.js. I don't find the corresponding bits of code in the latest production / dev versions.

in 2.11, dev is idnetical but one line up shifted.


// line 24

          //CKEditor support
          if (typeof(CKEDITOR) != 'undefined' ) {
            for (var instance in CKEDITOR.instances) {
              CKEDITOR.instances[instance].setData($('#' + instance).val());
            }
          }
...

//line 43
          if (typeof(CKEDITOR) != 'undefined' ) {
            for (var instance in CKEDITOR.instances) {
              CKEDITOR.instances[instance].setData($('#' + instance).val());
            }
          }
...

//line 60
        //CKEditor support
        if (typeof(CKEDITOR) != 'undefined' ) {
          for (var instance in CKEDITOR.instances) {
            CKEDITOR.instances[instance].setData($('#' + instance).val());
          }
        }


// line 99
  //CKEditor support
  if (typeof(CKEDITOR) != 'undefined') {
    for (var instance in CKEDITOR.instances) {
      CKEDITOR.instances[instance].updateElement();
    }
  }
vgalindus’s picture

vgalindus commented
StatusFileSize
new autosave_6.x-2.11_CKEDITOR4.patch1.07 KB

Hi jvieille,

you are right, this issue is for 6.x version and the patch I supplied is for 7.x, I have checked version 6.x and wrote a patch for it I have some projects were could be useful but this needs more testing. Right now seems to work with CKEditor v4.2 (I guess all v4 and above) and maximized. You should change css for autosave div to appear in full screen z-index: 9999.

Hope it helps.

BR