Problem/Motivation
\Drupal\package_manager_test_event_logger\EventSubscriber\EventLogSubscriber::logEventInfo logs to the drupal logger and then we need check this via the drupal UI in \Drupal\Tests\package_manager\Build\TemplateProjectTestBase::assertExpectedStageEventsFired . This is very complicated and hard to read.
If we instead logged to just a file it would be much easier to check.
Also it would solve a problem in #3357969: For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits which is that it is hard to wait for cron updates in detached process to finish. This is issue is major because it blocks that issue
Steps to reproduce
Proposed resolution
- Change
\Drupal\package_manager_test_event_logger\EventSubscriber\EventLogSubscriber::logEventInfolog to a json file that would have sub elements for each event that fired and which stage was associated - Change
\Drupal\Tests\package_manager\Build\TemplateProjectTestBase::assertExpectedStageEventsFiredassert the contents of the file.
Remaining tasks
After this issue is committed
In #3357969: For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits change \Drupal\Tests\automatic_updates\Build\CoreUpdateTest::waitForStageToBeDestroyed to wait for expected events to have been fired
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3378774
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
phenaproximaComment #5
phenaproximaComment #6
tedbowComment #7
phenaproximaComment #8
tedbowLooks good if tests pass!
Comment #9
phenaproximaComment #11
phenaproxima