Problem/Motivation

Implement addDotGitFolder in package_manager/tests/src/Traits/FixtureUtilityTrait.php which
accepts a path where we want to create a .git folder.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3335802

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar.podey created an issue. See original summary.

omkar.podey’s picture

omkar.podey commented
Issue summary: View changes
omkar.podey’s picture

omkar.podey commented
Issue summary: View changes
omkar.podey’s picture

omkar.podey commented
Issue summary: View changes
Related issues: +#3315834: GitExcluder should not ignore .git directories that belong to packages installed by Composer
omkar.podey’s picture

omkar.podey commented
Title: Add addDotGitFolder functionality to package_manager/tests/src/Traits/FixtureUtilityTrait.php » Add addDotGitFolder functionality to \Drupal\fixture_manipulator\FixtureManipulator

omkar.podey opened merge request !668

omkar.podey’s picture

omkar.podey commented

Added an unnecessary doc block will remove it once the tests pass.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Major
Issue tags: +blocker

This blocks #3315834: GitExcluder should not ignore .git directories that belong to packages installed by Composer, so matching priority.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Requested one small piece of extra test coverage 🤓

omkar.podey’s picture

omkar.podey commented
Assigned: omkar.podey » wim leers
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community

Beautifully clear and elegant merge request, with very clear test coverage too — and indeed good call to use FixtureManipulator instead of (Active|Stage)FixtureManipulator — both of those are just very thin wrappers around FixtureManipulator that merely add guarantees that they were indeed applied to active/stage dir respectively 👍

Let's get this in!

tedbow made their first commit to this issue’s fork.

omkar.podey’s picture

omkar.podey commented

I found a bug while making it work with #3315834: GitExcluder should not ignore .git directories that belong to packages installed by Composer push fix + test extension

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Needs work

@omkar.podey 1 more test change needed

omkar.podey’s picture

omkar.podey commented
Assigned: Unassigned » tedbow
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Nice improvement 😊🚢

  • tedbow committed 4e5e5b13 on 8.x-2.x authored by omkar.podey 
    Issue #3335802 by omkar.podey, tedbow: Add addDotGitFolder functionality...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed

Great!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.