Problem/Motivation

follow -up to #3304569: Validate package names are in the correct format in Installer

Steps to reproduce

Drupal\package_manager\Stage::require takes package names but we don't actually validate they are in the correct format so you can send project names and they will get saved directly.

Proposed resolution

check it is in the right form namespace/package_name and throw an exception.

We should a new test method in Drupal\Tests\package_manager\Kernel\StageTest

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Code Review
  • ☐ Automated tests needed/written?
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rahul_ created an issue. See original summary.

rahul_’s picture

Status: Active » Needs review
phenaproxima’s picture

Status: Needs review » Needs work
rahul_’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Status: Needs review » Needs work

Coding standards checks failing, looks like...

rahul_’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Status: Needs review » Needs work
rahul_’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Title: Validate package names are in the correct format in Stage » Stage::require() should validate the incoming package names
phenaproxima’s picture

Assigned: rahul_ » phenaproxima
phenaproxima’s picture

Assigned: phenaproxima » Unassigned
traviscarden’s picture

Status: Needs review » Reviewed & tested by the community
phenaproxima’s picture

  • phenaproxima committed 3efd96d on 8.x-2.x authored by rahul_
    Issue #3310901 by rahul_, phenaproxima, TravisCarden: Stage::require()...
phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Whew, that was...circuitous. Merged into 8.x-2.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

Issue tags: +core-mvp