Problem/Motivation
follow -up to #3304569: Validate package names are in the correct format in Installer
Steps to reproduce
Drupal\package_manager\Stage::require takes package names but we don't actually validate they are in the correct format so you can send project names and they will get saved directly.
Proposed resolution
check it is in the right form namespace/package_name and throw an exception.
We should a new test method in Drupal\Tests\package_manager\Kernel\StageTest
Remaining tasks
- ✅ File an issue about this project
- ☐ Code Review
- ☐ Automated tests needed/written?
Issue fork automatic_updates-3310901
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rahul_ commentedComment #4
phenaproximaComment #5
rahul_ commentedComment #6
phenaproximaCoding standards checks failing, looks like...
Comment #9
rahul_ commentedComment #10
phenaproximaComment #11
rahul_ commentedComment #12
phenaproximaComment #13
phenaproximaComment #14
phenaproximaComment #15
traviscarden commentedComment #16
phenaproximaComment #18
phenaproximaWhew, that was...circuitous. Merged into 8.x-2.x!
Comment #20
tedbow