The fieldset appears empty on node-add forms for node types that do not have any queues available. It should be hidden, if that's the case.

CommentFileSizeAuthor
#6 auto_nodequeue-only-add-fieldset-if-a-queue-is-available-1878986-6.patch.tar_.gz2.4 KBchetan-singhal
#4 auto_nodequeue-no_queues_hide_settings-1878986-3.patch1.77 KBsmira
#1 auto_nodequeue-no_queues_hide_settings-1878986-1.patch1.67 KBmstef

Comments

mstef’s picture

mstef commented
Status: Active » Needs review
StatusFileSize
new auto_nodequeue-no_queues_hide_settings-1878986-1.patch1.67 KB
mstef’s picture

mstef commented

On a side-note, you should consider changing the case of your labels to match the standards; ie, "Available Node Queues", should be "Available node queues".

smira’s picture

smira commented

based on mstef's patch i suggest using this variation that only shows tab if the auto_nodequeue feature is enabled for that form, instead of if $options are set

smira’s picture

smira commented
Issue summary: View changes
StatusFileSize
new auto_nodequeue-no_queues_hide_settings-1878986-3.patch1.77 KB
davidfells81@gmail.com’s picture

davidfells81@gmail.com commented

If someone wants to make a patch for the latest version I'll add it to a release. I've patched for nodequeue 3 support and this patch doesn't appear compatible.

chetan-singhal’s picture

chetan-singhal commented
StatusFileSize
new auto_nodequeue-only-add-fieldset-if-a-queue-is-available-1878986-6.patch.tar_.gz2.4 KB

I have add this patch for the following bugs and fetatures.

Bug solution:
1- Only add "Auto Node Queue" fieldset to node forms if a queue is available.
2- Remove $ID form the files. This is no longer needed in drupal 7.
3- Replace the multiple comments into single line comment inside the functions.

New Feature.

1- User can remove the node in available queues if not exists.
2- User can also add the node in available queues if not exists.

devd’s picture

devd commented

Hi Chetan,

You patch is good but next time upload any patch file with the .patch extension only.

devd’s picture

devd commented
Version: 7.x-1.x-dev » 7.x-2.0
Status: Needs review » Closed (fixed)

The patch 'auto_nodequeue-only-add-fieldset-if-a-queue-is-available-1878986-6.patch' has been ported in the release 7.x-2.0.