Does it works well with node access modules? e.g Can it show only the links/nodes which the user has access to? In that case how the caching would work since each user may be different? OG is one of the node access modules. So If I am part of multiple groups, will it show links only from groups I am member of?

Comments

jfberroyer’s picture

jfberroyer commented
Status: Active » Fixed

I don't know if it works with OG, probably not.
I didn't care about node access, but you are right, it will be useful. The next release will have a node_access condition (it's already in CVS).
For now, there is just a db_rewrite_sql when the associated nodes are selected from the cache table, so the associated nodes may be filtered by other modules.

ajayg’s picture

ajayg commented

I think just db_rewrite_sql at the right place is sufficient and that is how node_acess was supposed to be working. If it works for any one the node-access module it should theoratically work for all others including OG.

I am also liking your approach of putting db_rewrite_sql while reading from cache (rather then when it was put in cache) so that way when node_acess module is installed , instead of showing say 10 links, it will just show 7 links from cache table instead of combing through all the way from a full node table.

Now i have to try it.

jfberroyer’s picture

jfberroyer commented

I have done a few tests and I also think just db_rewrite_sql is sufficient, so I've deleted the node_access condition which needed node_load for each associated nodes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.