Hello,

I'm absolutely thrilled by this module! It's a great platform for other modules. :)

I've installed Appbar and noticed some things. I think it's better to create for everyone of them a separate issue. So I start here with a small bug.

On the administration settings page I can choose a "minimum number of alerts to show". It seems like this setting can't be changed. Everytime I choose an other number and click on 'save' I always see only 5 alerts and this setting seems to fall back to the standard -> figure 5.

Please let me know if you need more information.

Regards,
Stefan

Comments

icecreamyou’s picture

icecreamyou commented
Assigned: Unassigned » icecreamyou
Status: Active » Reviewed & tested by the community

You are quite right. Line 77 of appbar.admin.inc needs to be changed from this:

  $form['appbar_max'] = array(

to this:

  $form['appbar_min'] = array(

I'll commit this change within the next few days.

icecreamyou’s picture

icecreamyou commented
Status: Reviewed & tested by the community » Fixed

Committed to dev

design.er’s picture

design.er commented

Great, it works. :)

I'm not sure an other bug(?) relates to this one but sometimes I see "Alerts (381 new)". Some minutes later it reduces to "Alerts (2 new)".
And sometimes it it shows for 2-3 seconds all alerts but switches back very fast the correct number of alerts I've chosen on the settings page (i.e. 10 alerts) again.
Should I open a new thread for this?

icecreamyou’s picture

icecreamyou commented

Frankly, I can't reproduce it, so I'm not going to be able to fix it, especially if you can't give me more information. A new thread will just sit there irritating me for awhile until I mark it "won't fix." You'll get the same answer as other issues I can't solve ("there's nothing in the code that would produce this... sounds like a server configuration problem... more information... blah blah blah").

So, if you really want to fix this, my strong suggestion is to figure it out yourself. If you solve it and it really is a bug in the module, then open a new issue and post a patch in the queue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.