Problem/Motivation

Getting following error.

FILE: /var/www/html/modules/contrib/api_proxy/modules/api_proxy_example/src/Plugin/api_proxy/Example.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
60 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 3 secs; Memory: 8MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/api_proxy/

Proposed resolution

Above error need to be fixed.

CommentFileSizeAuthor
#2 3339800-2.patch685 bytessamitk

Issue fork api_proxy-3339800

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new685 bytes

Above error is fixed.

Sonal Gyanani’s picture

Assigned: Unassigned » Sonal Gyanani

Sonal Gyanani’s picture

Assigned: Sonal Gyanani » Unassigned

Patch #2 applied successfully, error is fixed now.
RTBC +1

charchil khandelwal’s picture

Assigned: Unassigned » charchil khandelwal

I will review this MR.

charchil khandelwal’s picture

Assigned: charchil khandelwal » Unassigned
Status: Needs review » Reviewed & tested by the community

MR !10 looks good to me.
All the errors and warnings are fixed now.
So moving it to RTBC.

Thanks.

e0ipso’s picture

Status: Reviewed & tested by the community » Postponed

Holding off for now.